typescript-node: clean up require and import #6947
Conversation
… instead of import statement
macjohnny
changed the title
| import localVarRequest from 'request'; | ||
| import http from 'http'; | ||
| {{/supportsES6}} | ||
| {{^supportsES6}} | ||
| import localVarRequest = require('request'); |
There was a problem hiding this comment.
The import var = require does not make much sense to me. This should be probably const localVarRequest = require('request').
Or did I oversee something?
There was a problem hiding this comment.
Same for the other parts.
There was a problem hiding this comment.
Yeah thats right, i'll fix it :)
There was a problem hiding this comment.
I'm getting some typescript errors with const http = require. These are "TS2503: Cannot find namespace 'http'." and "error TS4055: Return type of public method from exported class has or is using private name 'http'.". As described here: https://stackoverflow.com/questions/31173738/typescript-getting-error-ts2304-cannot-find-name-require there are some ways to make this work, but to be honest i don't see a reason why to make a difference at this point. All other modules are imported with the "import .. from" stmt independent of the ES6 flag. So i removed the switch and changed the tsconfig to make the imports http/request work. What do you think about this solution?
There was a problem hiding this comment.
For TypeScript to use these you need the types for the Nodejs internal ones. Basically @types/node.
There was a problem hiding this comment.
The current solution should be fine.
You might want to remove the space inside the square brackets (it is either a space or x as single character) ;-) |
|
@laubfall could you please fix the CI issues? |
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
|
I just pushed 547e305 to fix the CI failure. Let's see how that goes. |
| model/pet.ts | ||
| model/tag.ts | ||
| model/user.ts | ||
| model/./apiResponse.ts |
There was a problem hiding this comment.
Why this change? ./ makes not much sense in my opinion.
There was a problem hiding this comment.
Agreed ./ is not needed. We'll tackle it separately.
There was a problem hiding this comment.
Ok, so there is nothing left here to todo for the PR?
Thanks, i looked into the CI Failure but did not saw the reason why the build failed |
|
Shippable CI failure not related to this PR. |
* master: (121 commits) [PowerShell] better publishing workflow (#7114) [aspnetcore] Typo issues in docs and generated code (#7094) fix http signaure auth in build.sbt (#7110) fix for the issue facing spec invlolving arrayschema structure with ref (#6310) [csharp-netcore] added cancellation tokens to async calls (#7077) [PS] Allow CI to publish the module (#7091) [Dart] Treat float as double (#6924) [Java][jersey2]Fix gradle HttpSignatureAuth dependencies (#7096) move maven,gradle tests to shipppable ci (#7108) [MARKDOWN] Fix issue 6089 with property and parameter names (#6105) [BUG] Multi-Part content type in response ignores properties of composed schema (allOf/oneOf) (#6073) [online] Fix for version conflicts with springfox/boot (#7102) skip some installations to shorten build time [Go][Exp] better code format (#7088) Fix Shippable CI (#7097) typescript-node: clean up require and import (#6947) commented out perl, bash tests to reduce build time Add a link to conference paper (#7086) Add a link to the blog post at qiita (#7084) migrate typescript.sh to new config format (#7078) ...
… instead of import statement
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.master@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)